Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change NOTICE to STATUS to address #891 #899

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

cary-ilm
Copy link
Member

From the CMake documentation:

  • NOTICE: Important message printed to stderr to attract user’s attention.
  • STATUS: The main interesting messages that project users might be interested in.

These messages simply state what is happening, so STATUS seems so they don't seem appropriate for stderr.

Signed-off-by: Cary Phillips cary@ilm.com

From the CMake documentation:

* NOTICE: Important message printed to stderr to attract user’s attention.
* STATUS: The main interesting messages that project users might be interested in.

These messages simply state what is happening, so STATUS seems so they
don't seem appropriate for stderr.

Signed-off-by: Cary Phillips <cary@ilm.com>
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL I should be using STATUS in many cases in my cmake work

@lgritz
Copy link
Contributor

lgritz commented Jan 16, 2021

The one I really covet is the CMake >= 3.15 message (VERBOSE, ...), which prevents you from having to surround verbose-only status messages inside if (VERBOSE) ... endif() blocks. A bunch of projects including this one only assume cmake 3.12, but maybe some day we can hope to bump that ASWF-wide.

@cary-ilm cary-ilm merged commit dd87e54 into AcademySoftwareFoundation:master Jan 18, 2021
@cary-ilm cary-ilm added the Build A problem with building or installing the library. label Mar 21, 2021
@cary-ilm cary-ilm deleted the cmake-message branch May 18, 2021 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build A problem with building or installing the library. v3.0.0-beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants